Enforce system python in RPC calls#37
Merged
Merged
Conversation
As the RPC is executed with the user 'user', its PATH may point to a another python than /usr/bin/python3 with the right modules installed from the package manager. In this case the RPC fail with an import error. This commit enforce the use of the system python.
This was referenced Feb 3, 2026
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026021104-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026020304-devel&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/166096#dependencies 33 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:12 performance degradations
Remaining performance tests:98 tests
|
This was referenced Feb 3, 2026
This was referenced Feb 11, 2026
Merged
marmarek
approved these changes
Feb 12, 2026
marmarek
left a comment
marmarek
left a comment
Member
There was a problem hiding this comment.
I think NixOS folks won't be happy about this change, but everywhere else it's correct thing to do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have this issue that my user space may use another python than the system one,
leading to import errors.
It is not totally clear if I should bear the responsibility of the default
python used by my userspace or if the RPC call should always use the system
python anyway, as their dependencies are installed by the package manager.
I tend to think the second.