Skip to content

Remove SO_REUSEPORT if on mac since it doesn't work #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quentin-Anthony merged 4 commits into from
Aug 6, 2025
Merged

Remove SO_REUSEPORT if on mac since it doesn't work #11

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0eeca02
Remove SO_REUSE if on mac since it doesn't work
nsarka Jul 23, 2025
e324bcd
Merge branch 'main' into nsarka/mac-fix
nsarka Jul 23, 2025
dc16cf9
Remove extra newlines
nsarka Jul 23, 2025
5edd521
Remove newline
nsarka Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions backends/socket/socket_backend.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@ static int init_server(nanompi_communicator_t *comm) {
}

// Try to reuse addr and port to avoid pesky bind: address in use errors >:(
// This is especially useful right now because the job launcher does not forward Ctrl+C signals
// to each process. That means after every run that errors or is Ctrl+C'd out, we get more stray
// processes
// TODO: It seems like this doesn't always work
if (setsockopt(comm->socket_info.server_fd, SOL_SOCKET, SO_REUSEADDR | SO_REUSEPORT, &opt,
sizeof(opt))) {
// This is especially useful right now because the job launcher does not forward Ctrl+C signals to each process.
// That means after every run that errors or is Ctrl+C'd out, we get more stray processes
int so = SO_REUSEADDR;
#ifndef __APPLE__
// This option does not work on my (Nick's) mac
so |= SO_REUSEPORT;
#endif
if (setsockopt(comm->socket_info.server_fd, SOL_SOCKET, so, &opt, sizeof(opt))) {
perror("setsockopt");
status = MPI_ERR_OTHER;
goto close;
Expand Down Expand Up @@ -81,7 +83,6 @@ static int init_server(nanompi_communicator_t *comm) {
// out client_fds in rank order e.g. ranks are 0 1 2 0 connects to 1 and blocks 1 connects
// to 2 and blocks 2 accepts 1, unblocking 1. 1 is in rank order in 2's client_fds 2 accepts
// 0, 0 is in rank order in 2's client_fds 1 accepts 0, 0 is in rank order in 1's client_fds
// TODO: is this explanation necessary?
comm->socket_info.client_fds[i] =
accept(comm->socket_info.server_fd, (struct sockaddr *)&address, (socklen_t *)&addrlen);
}
Expand Down