Conversation
SilverAndro
requested review from
NoComment1105,
Oliver-makes-code,
PotatoPresident and
sschr15
| * @param direction The directions that this packet can be sent in. | ||
| * @param serializersModule The serializers module to be used for decoding | ||
| */ | ||
| public class SerializedPacketRegistration<P>( |
There was a problem hiding this comment.
It may be reasonable to add an alternative to this supporting class-based declarations in addition to the DSL-style declaration.
There was a problem hiding this comment.
Given theres no namespaces yet, ill probably throw that on the other objects i created
|
Why not use either of the existing CBOR encoder, getting rid of need for a custom format, and just dumping the resulting byte array, or codec serialization with a bytebuf Ops (something previously discussed over at QuiltMC/quilt-standard-libraries#180), enabling codec support? I'm sure sending identifiers in a packet is common enough for this to be appreciated. |
good idea, ill see about that after finals. gonna make this draft until then |
|
Is it okay if I port this and work on it? |
|
fine by me, probably needs a rewrite as suggested #69 (comment) |
4 participants
yeah 😎
Inspired by the concept of FabricMC/fabric-api#2820, banged out during class so might have fucked up some stuff.
Wasnt able to include a lot of the goodies like
encodeNbtand whatever because we dont have serializers for those atm, worth looking into if its possible with mixin or if we need chasm?Keeps compat with any java users wanting to parse this, nulls are encoded the same way as
Optionals and such, as you can see in this diagram of the serialized form of the sample data