Conversation
…tions, and Oshai's Kotlin Logging
|
Turns out adding a separate minecraft serialization library may not be strictly necessary as we already have our own. That said, Fudge's library does provide several types and convenience methods that we do not have yet, as well as the rather large advantage of serializing to |
| includeModApi(libs.serialization.minecraft) | ||
| includeApi(libs.collections.immutable) | ||
| includeApi(libs.klogging) |
There was a problem hiding this comment.
Looking at how the project is structured, I think those additions would have to go either in the core or in the library subproject.
There was a problem hiding this comment.
I've read the project's README, and it seems like core is for the Kotlin adapter, and library is for FLK and other qkl specific things. So it made sense to us that each "sublibrary" in QKL should be declared in the root project. We could move that tho, not a problem.
|
As for the weird git diff - this PR also sorts dependency versions alphabetically. |
NBTandUUID. 142 KB in size.O(1)compared to mutable collections'O(n)) immutable collections. 238 KB in size.These libraries are very useful - and bundling them with KQL can save storage space, preventing multiple mods from bundling them each.