QMAPS-2033 add "add to home" infobox on mobile after the 5th visit#1161
QMAPS-2033 add "add to home" infobox on mobile after the 5th visit#1161xem wants to merge 3 commits into
Conversation
| }; | ||
|
|
||
| const visits = parseInt(get('visits') || 0) + 1; | ||
| set('visits', visits); |
There was a problem hiding this comment.
This is a good example of a side effect that we want to control more and safely separate from the component rendering.
If we put it here in the render function, we will increment visits each time this component is re-rendered, which can happen at any moment in the app not related to a single hit.
You can already see it in these cases:
- when the window is resized and the device is changed from desktop to mobile (as it's rendered as a child of a
DeviceContext.Provider) - after the box is displayed and we call
setClosed(true)
To ensure this increment happens only on mounting the component, you could put it inside a useEffect(…, [ ]).
But this still means if for some reason we unmount and remount this component during a user session, it will be counted twice.
So the safer approach IMO is to update this counter outside this component, where we are 100% sure we'll execute code only once per session. For example, as a sideEffect of RootComponent or in app_panel. The get can still happen here as it doesn't modify anything.
|
The |
2 participants
Description
add "add to home" infobox on mobile after the 5th visit
TODO: use com center link when it's ready
Screenshots