This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Refacto directions (using a store, converting DirectionPanel to functional, etc.)#1227
Draft
bbecquet wants to merge 19 commits into
Draft
Refacto directions (using a store, converting DirectionPanel to functional, etc.)#1227bbecquet wants to merge 19 commits into
bbecquet wants to merge 19 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Big overhaul of the directions feature… sadly not 100% finished :/ It's mostly complete but some details may have change and need to be tested thoroughly (ex: behavior of input fields, back/forward actions, mobile details, etc.).
The base idea is to introduce a top-level store (see https://fr.reactjs.org/docs/hooks-reference.html#usereducer and https://dev.to/jackent2b/the-best-couple-usecontext-usereducer-4e65) to manage the complex state transitions of this feature, and build on that to:
Why
Try to make DirectionPanel more maintainable and the whole direction feature more future-proof.