Custom Settlement Types Compatibility Patch - #189
Open
slelyukh wants to merge 2 commits into
Open
Conversation
Added a ton of if statements to not run functions when in non-base game settlements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds conditionals in the beginning of many Banner Kings functions that involve settlements. This conditional prevents Banner Kings functions from running on settlements that are not one of the base game settlement types (Village, Town, Castle, Hideout or RetirementSettlement).
My mod defines a custom settlement type called "Minor Faction Hideouts" that can work with this patch. This also allows Banner Kings to be compatible with any other mod that also defines a custom settlement type.
No original functionality is changed as this only affects custom settlement types and Banner Kings only works with base game settlement types.
[https://www.nexusmods.com/mountandblade2bannerlord/mods/6771/?tab=description&jump_to_comment=138548328](Nexus Mods Link)