Fix: Prevent crash caused by EscortBehavior with null TargetParty - #208
Open
xtended2l wants to merge 2 commits into
Open
Fix: Prevent crash caused by EscortBehavior with null TargetParty#208xtended2l wants to merge 2 commits into
xtended2l wants to merge 2 commits into
Conversation
Fix: Prevent EscortBehavior with null TargetParty via Harmony patch
Fix: Prevent EscortBehavior with null TargetParty via Harmony patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch uses Harmony to intercept
MobileParty.TargetPartyassignments. If a party hasAiBehavior == EscortPartybut the target is being set to null, the patch automatically resets the behavior toDoNothing().This prevents a rare but critical crash that occurs when AI strength evaluation methods access
TargetParty.Party.TotalStrengthwithout null checks.The fix is backward-compatible and safe for existing saves.