Skip to content

Bump 2.3.6#1132

Merged
robotpilot merged 13 commits intohumblefrom
main
Dec 15, 2025
Merged

Bump 2.3.6#1132
robotpilot merged 13 commits intohumblefrom
main

Conversation

@GyuH13
Copy link
Copy Markdown
Member

@GyuH13 GyuH13 commented Dec 15, 2025

#1130 : Support Pi camera launch in Docker containers
#1131 : Fix the Reset Trigger Service

Copilot AI review requested due to automatic review settings December 15, 2025 12:17
@github-project-automation github-project-automation bot moved this to 🌱 Todo in Platform Dec 15, 2025
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @GyuH13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant updates to the TurtleBot3 project, primarily focusing on expanding its compatibility and improving core functionalities. It integrates support for Raspberry Pi cameras within Docker environments for ROS2 Humble and Jazzy, allowing for more versatile sensor configurations. Additionally, the odometry reset mechanism has been refined to ensure a complete reset of the robot's estimated position and velocity, which is crucial for reliable robot operation. The changes also include general version updates across all packages and an updated issue reporting template to accommodate newer hardware and software versions.

Highlights

  • Enhanced Docker Support for Pi Camera: Dockerfiles for ROS2 Humble and Jazzy distributions now include necessary packages and build steps for libcamera, enabling Raspberry Pi camera functionality within Docker containers for TurtleBot3.
  • Improved Odometry Reset Service: The reset service in turtlebot3_node has been updated to also trigger a reset of the odometry pose and velocity, ensuring a more comprehensive reset of the robot's state.
  • Updated Issue Template: The ISSUE_TEMPLATE.md now includes options for Raspberry Pi 5, Ubuntu 24.04, and ROS2 Jazzy Jellyfish, reflecting support for newer hardware and software versions.
  • Version Bumps and Minor Updates: All core TurtleBot3 packages have been bumped to version 2.3.6, and the README.md has been updated to reflect noetic as a legacy branch and include a new driver link.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version to 2.3.6, incorporating fixes for the reset trigger service and adding Pi camera support in Docker. The changes are generally good, but I have identified a few areas for improvement. Specifically, the Dockerfiles can be optimized by combining layers and cleaning up build artifacts to reduce image size. More critically, I've found a couple of potential bugs in the odometry reset logic: one where a device command failure is silently ignored, and another where the odometry state is not fully reset, which could lead to incorrect calculations.

Comment thread turtlebot3_node/src/devices/reset.cpp
Comment thread turtlebot3_node/src/odometry.cpp
Comment thread docker/humble/Dockerfile
Comment thread docker/humble/Dockerfile
Comment thread docker/jazzy/Dockerfile
Comment thread docker/jazzy/Dockerfile
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the TurtleBot3 package versions from 2.3.4 to 2.3.6, incorporating fixes for the reset trigger service and adding Pi camera support in Docker containers for both Humble and Jazzy distributions.

Key Changes:

  • Implements reset_odometry service and client to fix reset trigger functionality
  • Adds Pi camera (libcamera) support in Docker environments with necessary dependencies
  • Updates license text format in teleop_keyboard.py from "BSD License 2.0" to more accurate "BSD 2-Clause Simplified License"

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
turtlebot3_teleop/script/teleop_keyboard.py Updates BSD license header text for clarity and accuracy
turtlebot3_teleop/setup.py Version bump to 2.3.6
turtlebot3_teleop/package.xml Version bump to 2.3.6
turtlebot3_teleop/CHANGELOG.rst Adds changelog entries for versions 2.3.5 and 2.3.6
turtlebot3_node/src/odometry.cpp Adds reset_odometry service implementation
turtlebot3_node/src/devices/reset.cpp Adds reset_odometry client to trigger odometry reset after calibration
turtlebot3_node/package.xml Version bump to 2.3.6
turtlebot3_node/include/turtlebot3_node/odometry.hpp Adds reset service declaration and trigger header include
turtlebot3_node/include/turtlebot3_node/devices/reset.hpp Adds reset_odom_client_ member declaration
turtlebot3_node/CHANGELOG.rst Documents reset trigger fix in version 2.3.6
turtlebot3_navigation2/package.xml Version bump to 2.3.6
turtlebot3_navigation2/CHANGELOG.rst Adds changelog entries for versions 2.3.5 and 2.3.6
turtlebot3_example/setup.py Version bump to 2.3.6
turtlebot3_example/package.xml Version bump to 2.3.6
turtlebot3_example/CHANGELOG.rst Adds changelog entries for versions 2.3.5 and 2.3.6
turtlebot3_description/package.xml Version bump to 2.3.6
turtlebot3_description/CHANGELOG.rst Adds changelog entries for versions 2.3.5 and 2.3.6
turtlebot3_cartographer/package.xml Version bump to 2.3.6
turtlebot3_cartographer/CHANGELOG.rst Adds changelog entries for versions 2.3.5 and 2.3.6
turtlebot3_bringup/package.xml Version bump to 2.3.6
turtlebot3_bringup/CHANGELOG.rst Adds changelog entries for versions 2.3.5 and 2.3.6
turtlebot3/package.xml Version bump to 2.3.6
turtlebot3/CHANGELOG.rst Documents both reset trigger fix (2.3.6) and Pi Camera support (2.3.5)
docker/jazzy/docker-compose.yml Adds /run/udev volume mount for device access
docker/jazzy/Dockerfile Adds camera-ros, libcamera v0.5.2, and related dependencies for Pi camera support
docker/humble/docker-compose.yml Adds /run/udev volume mount and fixes commented Dockerfile reference
docker/humble/Dockerfile Adds camera-ros, libcamera v0.5.2, nav2-route, and related dependencies
README.md Updates branch information (moves noetic to legacy) and adds coin_d4_driver reference
ISSUE_TEMPLATE.md Adds support for Raspberry Pi 5, Ubuntu 24.04, and ROS2 Jazzy Jellyfish

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker/humble/Dockerfile
Comment thread docker/jazzy/Dockerfile
Comment thread docker/jazzy/Dockerfile
Comment thread docker/humble/Dockerfile
Comment thread docker/jazzy/Dockerfile
Comment thread turtlebot3_node/src/odometry.cpp
Comment thread docker/humble/Dockerfile
Comment thread docker/jazzy/Dockerfile
Comment thread docker/humble/Dockerfile
@GyuH13 GyuH13 moved this from 🌱 Todo to 📝 Pull Request in Platform Dec 15, 2025
@GyuH13 GyuH13 added the bump Increase the version number to release label Dec 15, 2025
@robotpilot robotpilot merged commit e478e9a into humble Dec 15, 2025
34 checks passed
@github-project-automation github-project-automation bot moved this from 📝 Pull Request to 🚩Done in Platform Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump Increase the version number to release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants