Skip to content

fix(ci): Pass build_runs_on to multi_arch_build_portable_linux.yml#6069

Merged
geomin12 merged 1 commit into
mainfrom
users/geomin12/asan-perm-fix
Jun 23, 2026
Merged

fix(ci): Pass build_runs_on to multi_arch_build_portable_linux.yml#6069
geomin12 merged 1 commit into
mainfrom
users/geomin12/asan-perm-fix

Conversation

@geomin12

@geomin12 geomin12 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The multi_arch_release_linux.yml workflow was missing the build_runs_on parameter when calling multi_arch_build_portable_linux.yml, causing ASAN builds to use the default runner (azure-linux-scale-rocm) instead of the sanitizer runner (azure-linux-scale-rocm-heavy-ramdisk) selected by configure_multi_arch_ci.py.

This resulted in AWS IAM permission errors since the AWS runner role lacks permissions to the therock-dev-artifacts bucket.

Tested here: https://github.com/ROCm/TheRock/actions/runs/28047796953/job/83030388981#step:1:2 and properly passing it in

Tested here too: https://github.com/ROCm/TheRock/actions/runs/28039559307/job/83001994909#step:3:51

ISSUE ID #5937

The multi_arch_release_linux.yml workflow was missing the build_runs_on
parameter when calling multi_arch_build_portable_linux.yml, causing ASAN
builds to use the default runner (azure-linux-scale-rocm) instead of
the sanitizer runner (azure-linux-scale-rocm-heavy-ramdisk) selected by
configure_multi_arch_ci.py.

This resulted in AWS IAM permission errors since the AWS runner role
lacks permissions to the therock-dev-artifacts bucket.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@geomin12 geomin12 requested a review from nunnikri June 23, 2026 18:30
@geomin12 geomin12 added the ci:skip Skip all CI builds/tests for this PR label Jun 23, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot therock-pr-bot Bot added the Not ready to Review PR has unresolved policy failures — reviews blocked label Jun 23, 2026
@therock-pr-bot

therock-pr-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@therock-pr-bot therock-pr-bot Bot removed the Not ready to Review PR has unresolved policy failures — reviews blocked label Jun 23, 2026
@geomin12 geomin12 merged commit 598b0c6 into main Jun 23, 2026
56 of 83 checks passed
@geomin12 geomin12 deleted the users/geomin12/asan-perm-fix branch June 23, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip Skip all CI builds/tests for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants