Add hipFile examples#465
Open
j-stephan wants to merge 13 commits into
Open
Conversation
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Contributor
Author
|
hipFile is not yet part of TheRock. Need to wait for ROCm/TheRock#5217 and a follow-up PR before we can merge this. |
zichguan-amd
left a comment
zichguan-amd
left a comment
Collaborator
There was a problem hiding this comment.
Missing .gitignore
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
|
|
||
| SUBDIRECTORIES := hipFile |
Collaborator
There was a problem hiding this comment.
For this can we add a check similar to
rocm-examples/Libraries/Makefile
Lines 64 to 65 in c82e12d
1 task
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
derobins
added a commit
to ROCm/TheRock
that referenced
this pull request
Jun 16, 2026
## Motivation Add hipFile (from rocm-systems) to TheRock ## NOTE This PR depends upon a third-party sysdeps dependency PRs: * util-linux (for libmount): #5337 ## Technical Details * Add a new storage-libs stage/grouping * Add hipFile to CLAUDE.md * Add storage-libs to root CMakeLists.txt * Add THEROCK_ENABLE_HIPFILE CMake option (default ON) * Add THEROCK_ENABLE_STORAGE_LIBS CMake option (default ON) * Add storage-libs to build_tools/analyze_build_times.py * Add storage-libs to bump list in build_tools/bump_submodules.py * Add storage-libs and hipfile info to: * docs/development/build_system.md * docs/development/windows_support.md * Add new file: storage-libs/CMakeLists.txt * Add new file: storage-libs/artifact-hipfile.toml Packaging will be added in a follow-up PR This PR needed for rocm-examples' ROCm/rocm-examples#465 ## Jira ID ROCM-1261 AIHIPFILE-170 ## Test Plan Verify TheRock CI passes ## Test Result TBD ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
amd-chiranjeevi
pushed a commit
to ROCm/TheRock
that referenced
this pull request
Jun 17, 2026
## Motivation Add hipFile (from rocm-systems) to TheRock ## NOTE This PR depends upon a third-party sysdeps dependency PRs: * util-linux (for libmount): #5337 ## Technical Details * Add a new storage-libs stage/grouping * Add hipFile to CLAUDE.md * Add storage-libs to root CMakeLists.txt * Add THEROCK_ENABLE_HIPFILE CMake option (default ON) * Add THEROCK_ENABLE_STORAGE_LIBS CMake option (default ON) * Add storage-libs to build_tools/analyze_build_times.py * Add storage-libs to bump list in build_tools/bump_submodules.py * Add storage-libs and hipfile info to: * docs/development/build_system.md * docs/development/windows_support.md * Add new file: storage-libs/CMakeLists.txt * Add new file: storage-libs/artifact-hipfile.toml Packaging will be added in a follow-up PR This PR needed for rocm-examples' ROCm/rocm-examples#465 ## Jira ID ROCM-1261 AIHIPFILE-170 ## Test Plan Verify TheRock CI passes ## Test Result TBD ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
Signed-off-by: Jan Stephan <jan.stephan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds examples for hipFile, a new
rocm-systemscomponent.Technical Details
Supports all ROCm-capable GPUs, but only works on Linux.
Test Plan
Currently testing locally on Linux machines.
Test Result
Will update once results are obtained.
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist