Skip to content

fix aiter err of quarkptpcfp8#649

Merged
tjtanaavllm merged 2 commits into
llama_fp8_03122025from
lhy/fix_quark_aiter_ptpc
Sep 2, 2025
Merged

fix aiter err of quarkptpcfp8#649
tjtanaavllm merged 2 commits into
llama_fp8_03122025from
lhy/fix_quark_aiter_ptpc

Conversation

@lihaoyang-amd

@lihaoyang-amd lihaoyang-amd commented Aug 31, 2025

Copy link
Copy Markdown

Using the ptpc kernel of aiter will preshuffle the weights. The code lacks support for preshuffling for quark format;
We should add it.

Signed-off-by: Haoyang Li <lihaoyang0109@gmail.com>
@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Haoyang Li <lihaoyang0109@gmail.com>
@tjtanaavllm

Copy link
Copy Markdown

LGTM. Thank you for the fix

@tjtanaavllm tjtanaavllm merged commit 294874d into llama_fp8_03122025 Sep 2, 2025
5 checks passed
@gshtras gshtras deleted the lhy/fix_quark_aiter_ptpc branch September 25, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants