update README and update fp8 gemm dispatch for gfx95#772
Merged
Conversation
Signed-off-by: zhuyuhua-v <yuhzhu@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR targets ROCm FP8 gemm, since AITER’s FP8 GEMM implementation now supports multiple platforms, the previous
is_fp8_fnuzcheck is no longer necessary.Test results show that after removing this
is_fp8_fnuzcheck, AITER FP8 GEMM consistently outperforms the original VLLM Triton GEMM on MI355 across various scenarios, while maintaining accuracy.Test Plan
The following tests validate DeepSeek-V3 model by collecting benchmark metrics and performing correctness tests through lm_eval.
vLLM server launch command:
Benchmark commands:
Accuracy commands:
lm_eval --model local-completions --tasks gsm8k --model_args model=${model},base_url=http://127.0.0.1:8000/v1/completions --batch_size 100Test Result
Benchmark Result
deepseek-ai/DeepSeek-V3 on MI355, input-len/output-len: 1k/1k
deepseek-ai/DeepSeek-V3 on MI355, input-len/output-len: 8k/1k
Acuracy Result