Skip to content

Models can be null so added a check #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jesse-good246 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Models can be null so added a check #1794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Google Cloud Translation Provider/GoogleAPI/V3Connector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ public async Task<List<CombinedModel>> GetV3TranslationModelsAsync()
var jsonResponse = await response.Content.ReadAsStringAsync();
var modelsResponse = JsonConvert.DeserializeObject<TranslationModelsResponse>(jsonResponse);

return modelsResponse.Models;
return modelsResponse.Models ?? [];
}

_logger.Error($"Error: {response.StatusCode} - {await response.Content.ReadAsStringAsync()}");
Expand Down Expand Up @@ -280,7 +280,7 @@ public async Task<List<CombinedModel>> GetProjectCustomModels()

// Add V3 translation models while checking for duplicates
var v3Models = await GetV3TranslationModelsAsync();

foreach (var model in v3Models)
{
var existingModel = combinedModels.FirstOrDefault(a =>
Expand Down
Loading