e2e: add test suite with controller-runtime client - #15
Merged
Conversation
Collaborator
Author
Rakshith-R
force-pushed
the
add-e2e
branch
3 times, most recently
from
March 23, 2026 03:08
2d97f86 to
b3013ad
Compare
Madhu-1
reviewed
Mar 23, 2026
Madhu-1
left a comment
Madhu-1
left a comment
Member
There was a problem hiding this comment.
Have a general comment on code readability, let's not split the lines wheever its possible. it becomes hard to read the code.
Comment on lines
+51
to
+55
| suiteConfig, reporterConfig := | ||
| GinkgoConfiguration() | ||
| suiteConfig.FailFast = true | ||
| RunSpecs(t, "e2e suite", | ||
| suiteConfig, reporterConfig, |
Comment on lines
+62
to
+76
| Expect( | ||
| clientgoscheme.AddToScheme(scheme), | ||
| ).To(Succeed()) | ||
| Expect( | ||
| volsyncv1alpha1.AddToScheme(scheme), | ||
| ).To(Succeed()) | ||
| Expect( | ||
| snapv1.AddToScheme(scheme), | ||
| ).To(Succeed()) | ||
|
|
||
| cfg := ctrl.GetConfigOrDie() | ||
| var err error | ||
| k8sClient, err = client.New( | ||
| cfg, client.Options{Scheme: scheme}, | ||
| ) |
Comment on lines
+80
to
+82
| k8sClientSet, err = | ||
| kubernetes.NewForConfig(cfg) | ||
| Expect(err).NotTo(HaveOccurred()) |
Member
There was a problem hiding this comment.
same here as well, please take care of it in all the places
| type driverConfig struct { | ||
| name string | ||
| provider string | ||
| sc string |
Member
There was a problem hiding this comment.
lets use a full naming convention
Comment on lines
+85
to
+92
| name: "rbd", | ||
| provider: "rook-ceph." + | ||
| "rbd.csi.ceph.com", | ||
| sc: "rook-ceph-block", | ||
| vsClass: "csi-rbdplugin-snapclass", | ||
| volumeMode: ptr.To( | ||
| corev1.PersistentVolumeBlock), | ||
| accessMode: corev1.ReadWriteOnce, |
Member
There was a problem hiding this comment.
any specific reason to add rbd?
Collaborator
Author
There was a problem hiding this comment.
any specific reason to add rbd?
rbd mover+ worker is done too.
| Equal(corev1.ClaimBound), | ||
| ) | ||
| }).WithTimeout( | ||
| 2 * time.Minute, |
Member
There was a problem hiding this comment.
lets have this as configurable value
Rakshith-R
force-pushed
the
add-e2e
branch
2 times, most recently
from
March 23, 2026 06:35
308cefc to
db9a3ef
Compare
- Replace utils-based CertManager setup with controller-runtime and client-go clients for typed access to VolSync CRDs, VolumeSnapshots, and core resources - Split e2e tests into helpers, manual trigger, and schedule trigger files - Add parameterized tests across nfs, cephfs, and rbd drivers - Add FailFast config and change namespace to rook-ceph - Extract debug log collection into debugAfterEach helper - Add createRS to codespell ignore list - Promote k8s.io/utils to a direct dependency E2E now covers most of the scenarios: - data write + validation - 3 drivers - copyMethod: direct and copy - triger: - RepSource: schedule, manual - RepDestination: schedule, manual, None Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Rakshith R <rar@redhat.com>
Madhu-1
approved these changes
Mar 23, 2026
iPraveenParihar
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E2E now covers most of the scenarios: