bundle: fix CSV replaces field not being applied - #25
Merged
Conversation
Three bugs prevented the replaces field from appearing in the generated CSV: - REPLACES variable was never defined in the Makefile - JSON patch used "replace" op on a non-existent path (RFC 6902 requires the path to exist); changed to "add" - Patch target name was v0.0.1 but base CSV name is v0.0.0 Also guard the patch with ifneq so an empty REPLACES does not inject a blank replaces field, and remove the broken seed patch from the bases kustomization.yaml. Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Rakshith R <rar@redhat.com>
Rakshith-R
force-pushed
the
worktree-fix-replaces
branch
from
July 28, 2026 13:11
bd6eea4 to
4ede8f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs prevented the replaces field from appearing in the generated CSV:
Also guard the patch with ifneq so an empty REPLACES does not inject a blank replaces field, and remove the broken seed patch from the bases kustomization.yaml.
Assisted-by: Claude noreply@anthropic.com