refactor: Update to use INavigable instead of ASTNode.#491
Merged
Conversation
Collaborator
|
Looks reasonable and the code feels way cleaner without all the extra casts. Please use |
Contributor
|
I'm working on getting tests fixed in #496 so please actually just leave the tests alone to avoid merge conflicts. The build errors are blocking for me, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on RaspberryPiFoundation/blockly#8992 in core. It updates the keyboard experiment to use the new
INavigableinterface rather than ASTNode. It also temporarily disables the workspace cursor, as it is incompatible with the new approach.The
FieldColourplugin will need to be updated; in the meantime, navigating to a block with a colour field will break. I believe this is also the cause of the remaining test failures.