fix: Export registerFlyoutCursor as a static method#788
Merged
gonfunko merged 1 commit intoFeb 10, 2026
Merged
Conversation
Collaborator
|
This is needed sooner because this is affecting a live issue in makecode we should do a patch release of this after merging, we were already aiming to do one for core next week ish so we should test/release this as well |
gonfunko
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #756
Since v3.0.1 the flyout has been using a
LineCursorwhich cannot navigate to flyout labels or buttons. If the button or label is the first item in the flyout, it is focussed by default when moving focus from the toolbox to the flyout, but cannot be navigated to otherwise.I've added this as a static method following existing convention, but just
export {registerFlyoutCursor} from './flyout_cursor';would work if it needs to be a separate function.