Skip to content

update documentation with uninformative example#621

Open
RetrospectiveRotations wants to merge 2 commits intomainfrom
document_uninformative_node
Open

update documentation with uninformative example#621
RetrospectiveRotations wants to merge 2 commits intomainfrom
document_uninformative_node

Conversation

@RetrospectiveRotations
Copy link
Copy Markdown

@RetrospectiveRotations RetrospectiveRotations commented Mar 24, 2026

still fails because of missing rules for mea/var of Uninformative node

@Nimrais will take a look

also see here ReactiveBayes/ReactiveMP.jl#588

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.28%. Comparing base (08d58ca) to head (f7b76d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          26       26           
  Lines        2135     2135           
=======================================
  Hits         1714     1714           
  Misses        421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bvdmitri
Copy link
Copy Markdown
Member

Is there a corresponding PR for ReactiveMP or BayesBase? Cannot find it

@RetrospectiveRotations
Copy link
Copy Markdown
Author

RetrospectiveRotations commented Mar 26, 2026

Is there a corresponding PR for ReactiveMP or BayesBase? Cannot find it

No since the hacky workaround of setting the mean/variance to 0 is not valid. In the linked beta-bernoulli example, it would treat the uninformative entries as 'false' leading to a wrong posterior (i.e., not equal to the prior).

I think it should do the same as 'missing', but without computing predictions (and computation of free energy should still be possible).

@bvdmitri
Copy link
Copy Markdown
Member

Then maybe we drop this new feature? We can always pass missing there, yeah it activates the prediction, but I don't see a big different from what is proposed here (unless I missed it, pun intented)

@RetrospectiveRotations
Copy link
Copy Markdown
Author

Then maybe we drop this new feature? We can always pass missing there, yeah it activates the prediction, but I don't see a big different from what is proposed here (unless I missed it, pun intented)

It is not a new feature since it is already in ReactiveMP. There is also no documentation for it, hence this PR. But maybe I don't understand correctly why it is originally implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants