update documentation with uninformative example#621
update documentation with uninformative example#621RetrospectiveRotations wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 80.28% 80.28%
=======================================
Files 26 26
Lines 2135 2135
=======================================
Hits 1714 1714
Misses 421 421 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there a corresponding PR for ReactiveMP or BayesBase? Cannot find it |
No since the hacky workaround of setting the mean/variance to 0 is not valid. In the linked beta-bernoulli example, it would treat the uninformative entries as 'false' leading to a wrong posterior (i.e., not equal to the prior). I think it should do the same as 'missing', but without computing predictions (and computation of free energy should still be possible). |
|
Then maybe we drop this new feature? We can always pass |
It is not a new feature since it is already in ReactiveMP. There is also no documentation for it, hence this PR. But maybe I don't understand correctly why it is originally implemented. |
still fails because of missing rules for mea/var of Uninformative node
@Nimrais will take a look
also see here ReactiveBayes/ReactiveMP.jl#588