Conversation
Contributor
🤖 Code FormattingYour PR still has some code formatting issues. I've updated PR #623 with the necessary formatting changes. You can merge that PR into this branch to fix the code style check. Alternatively, you can run |
bvdmitri
reviewed
Mar 25, 2026
Member
bvdmitri
left a comment
bvdmitri
left a comment
There was a problem hiding this comment.
I'm ok to merge, but suggested to update the docstring
Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>
bvdmitri
added a commit
that referenced
this pull request
Apr 7, 2026
…632) * Integrate ReactiveMP event handler and enhance documentation (#615) * initial integration of ReactiveMP event handler * implement a more complex test * rename event handler to callbacks to be more aligned with ReactiveMP * update references to the callbacks in the documentation * use ReactiveMP.invoke_callback * fix the on_marginal_update callback invokation * rename benchmark callbacks file * restore the removed benchmark file lol * make format * checkpoint * adapt to changes in ReactiveMP * merge stricter formatting options * sync with ReactiveMP * latest changes in ReactiveMP * allow callbacks be any structure as in ReactiveMP * add Callbacks manual and update the related documentation * update docs * introduce StopIteration struct, make the callbacks use that instead of true/false * support benchmark = true keyword argument * fix broken tests * make format * update benchmarks * add simple tracer * 2prev * refactor to use ReactiveMP.Event structure * improve the documentation * update to latest changes in ReactiveMP * update the debugging section * update benchmark * improve printing a bit * comment-out-trace-show * TraceEvent: turn commented Base.show into Base.summary * Fix test to match changed TestEvent summary show method * Store trace time to TracedEvent (#622) * Store trace time to TracedEvent * Update trace_tests.jl * Apply suggestion from @bvdmitri Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com> --------- Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com> * Trace ID for Events (#626) * sprint for summary test * partial refactor, update postprocessing and inference.jl * update remaining files and the documentation * fix several bugs by hand * update the documentation build * update docs, add migration guide, update CHANGELOG * remove the plan --------- Co-authored-by: Raphael-Tresor <40422324+Raphael-Tresor@users.noreply.github.com> Co-authored-by: Fons van der Plas <fonsvdplas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stores the time of a TraceEvent, which is useful for observability. ✨