fix: common checkpoint selection - #1517
Merged
KolbyML merged 2 commits intoJul 16, 2026
Merged
Conversation
Dsorken
requested review from
Kayden-ML,
KolbyML and
shariqnaiyer
as code owners
July 10, 2026 07:55
looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
In cases where more than two peers do not have identical checkpoints and there is then no common checkpoint to select Ream will stall waiting for a resolution that is not guaranteed to happen. Meaning there is a chance that ream has a chance to get stuck in a still functioning network.
How was it fixed?
The fix is to add a selection system to break ties in this case. One common way to do so is cluster selection where Ream will look at all checkpoints available and select the highest checkpoint that is not an outlier, where an outlier would typically only pop up in the event a peer re-orgs and continues on the re-org path without the majority of peers being in agreement. This way Ream still chooses the fastest peer without choosing an incorrect peer.
To-Do