feat: add forward syncer - #639
Merged
Merged
Conversation
KolbyML
force-pushed
the
work-on-forward-sync
branch
from
July 12, 2025 21:56
ef6ea19 to
b381870
Compare
jihoonsong
reviewed
Jul 13, 2025
| use super::{MAX_BLOCKS_PER_REQUEST, peer_range_downloader::Range}; | ||
|
|
||
| /// The size of blobs is 1 MB (1_048_576 bytes) | ||
| const BLOB_SIZE: u64 = 1_048_576; |
Contributor
There was a problem hiding this comment.
Isn't blob size 128 KB?
Contributor
Author
There was a problem hiding this comment.
Yeah my bad, I will update that
KolbyML
force-pushed
the
work-on-forward-sync
branch
4 times, most recently
from
July 13, 2025 18:43
b62123a to
3e04a93
Compare
KolbyML
force-pushed
the
work-on-forward-sync
branch
from
July 13, 2025 23:22
3e04a93 to
1e7f6c7
Compare
KolbyML
marked this pull request as ready for review
July 13, 2025 23:23
Kayden-ML
approved these changes
Jul 13, 2025
Kayden-ML
left a comment
Kayden-ML
left a comment
Contributor
There was a problem hiding this comment.
Looks good nice work 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong?
We can't sync forward from the initial checkpoint
How was it fixed?
Implement a forward syncer which takes our connected peers, downloads blocks and blobs, and executes them till we get to the finalized point.
What I will do in follow up PR's
Currently syncing blobs will eventually freeze due to peers never responding and we don't implement timing out requests yet, so I need to implement timing out P2P requests.