Fix pretendo online island issues#251
Merged
RedShyGuy merged 4 commits intoRedShyGuy:release/3.3.0from Mar 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two online island issues related to Pretendo, enabled by default
Certain islands cannot be joined
There is an issue for this here. This happens because the server does (unnecessary?) changes to the session to be joined/created on auto-matchmaking but not to sessions created by other means; the fix just does the same changes as the server for those sessions. However, if this ever gets resolved on the server, this fix will probably cause issues and need to be removed
When there is >= 3 players in the lobby and the host leaves, the other players will get an error
When the host leaves, the chosen new host creates a new session and waits for the other player(s) to join. On the other's side, the principal ID of the new host is remembered, and used to find out the ID of the newly created session to join using FindByOwner. This method looks to be unimplemented on the server. This fix reimplements it
Also added a dev code to make a private island for easier testing.
Thanks to @FoofooTheGuy for helping test this