update views checking for text in a more secure way#315
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors duplicate code for checking empty rich text fields by introducing a centralized text_in_block() utility function. The changes consolidate similar logic across three check utility files (notizie, luoghi, and eventi) that was previously checking for empty block content inline.
Key changes:
- Replaced inline block text extraction with calls to
text_in_block()utility - Added import for
text_in_blockfromdesign.plone.contenttypes.utilsin three files - Updated CHANGES.rst with release notes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| check_notizie.py | Replaced inline logic for checking empty descrizione_estesa with text_in_block() call |
| check_luoghi.py | Replaced inline logic for checking empty modalita_accesso with text_in_block() call |
| check_eventi.py | Replaced inline logic for checking empty prezzo with text_in_block() call |
| CHANGES.rst | Added release notes documenting the fixes for empty rich text checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull Request Test Coverage Report for Build 18965384374Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.