MOD-14126 [TESTS] - Do not MARK-INTERNAL-CLIENT on older redis version#88
Merged
Conversation
|
|
galcohen-redislabs
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MARK-INTERNAL-CLIENTis not supported on redis < 8.0, the tests works be cause in older versions its still using the user/pass mechanismNote
Low Risk
Test-only and CI workflow changes; main risk is masking genuine Redis 8+ permission issues or changing CI signal by allowing other matrix jobs to continue after a failure.
Overview
Updates CI matrix strategy on Linux and macOS to set
fail-fast: false, so failures on one Redis version don’t cancel the remaining matrix runs.Refactors Python tests to only run
DEBUG MARK-INTERNAL-CLIENTwhen the Redis server version is>= 8.0.0, via a new helperpromote_internal_client_if_supported, and replaces ad-hoc try/except blocks in cluster init and network tests with this gated call.Written by Cursor Bugbot for commit 5e0406d. This will update automatically on new commits. Configure here.