MOD-14289 - wrapp EXECUTION_DEFAULT_MAX_IDLE_MS with ifdef so VG will override it#90
Merged
Merged
Conversation
AvivDavid23
approved these changes
Apr 5, 2026
TalBarYakar
force-pushed
the
tal.ba/bug/exec_timeout_vg
branch
from
cc1e92c to
aeb6457
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: a small preprocessor change that only affects the default idle-timeout constant when no external definition is provided.
Overview
Wraps the
EXECUTION_DEFAULT_MAX_IDLE_MSdefinition insrc/mr.cwith#ifndef/#endifso builds can override the default (5000ms) via a compile-time define without modifying the source.Reviewed by Cursor Bugbot for commit aeb6457. Bugbot is set up for automated code reviews on this repo. Configure here.