Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughStandardized CI workflow string quoting/spacing, added Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Calcit/tooling dependencies and regenerates the serialized Calcit output, alongside small repo hygiene/CI adjustments.
Changes:
- Bump
@calcit/procs(and related lockfile entries) from0.12.1to0.12.9. - Update Calcit dependency metadata (
deps.cirru) and regeneratecompact.cirru(including Respo package version update). - Tweak CI workflow formatting/commands and ignore Calcit snippet artifacts.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Bumps @calcit/procs dependency version. |
yarn.lock |
Updates lock entries for the bumped dependencies (incl. @cirru/parser.ts). |
deps.cirru |
Updates :calcit-version and pins calcit-lang/lilac to 0.5.1. |
compact.cirru |
Regenerated output reflecting new versions/schema. |
.gitignore |
Ignores .calcit-snippets/. |
.github/workflows/tests.yaml |
Reformats steps and changes cr invocation in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deps.cirru`:
- Line 4: The dependency entry "|calcit-lang/lilac |0.5.1" is invalid because
version 0.5.1 doesn't exist; update the deps.cirru entry for calcit-lang/lilac
by either specifying a valid published version or removing the explicit version
(leave it as the module name only) so the loader resolves the module, and verify
resolution succeeds (adjust the "|calcit-lang/lilac |0.5.1" line accordingly).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 30984e15-bb5c-406c-bbb6-dd76ec504afa
📒 Files selected for processing (4)
.github/workflows/tests.yaml.gitignorecompact.cirrudeps.cirru
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@compact.cirru`:
- Around line 2272-2277: The namespace declaration includes a self-import
causing a circular require: remove the self-reference "respo.test.comp.todolist
:refer $ comp-todolist" from the ns require list so the namespace no longer
requires itself; update the ns form around ns respo.test.comp.todolist $
:require to only include external deps (e.g., keep respo.test.comp.task and
respo.core) and ensure any use of comp-todolist within the file refers to the
local definition rather than an imported symbol.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 44d6717d-099f-4d54-a55f-c3378398fadc
📒 Files selected for processing (3)
compact.cirrudeps.cirrudocs/Respo-Agent.md
💤 Files with no reviewable changes (1)
- deps.cirru
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/guide/styles.md`:
- Line 73: Fix the grammar in the explanatory sentence containing the snippet
"`&` will be replace by a string of `className`" by changing "replace" to the
past participle "replaced" so it reads "`&` will be replaced by a string of
`className`" (this applies to the sentence that also references `&:hover`).
In `@docs/Respo-Agent.md`:
- Line 137: Update the misleading note about pipe-prefixed strings so the
JSON-string form includes the leading pipe; replace the incorrect example that
says the JSON string is "hello" with the correct form "\"|hello\"" (matching the
AST string node examples like "\"|Hello\""), and ensure any accompanying
explanation clarifies that pipe-prefixed strings must keep the leading "|" in
CLI/JSON payloads.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c99ee244-0912-48b4-b53c-890045285b4a
📒 Files selected for processing (3)
docs/Respo-Agent.mddocs/guide/base-components.mddocs/guide/styles.md
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/guide/styles.md (1)
156-156:⚠️ Potential issue | 🟡 MinorFix the grammar error: "will be replace" → "will be replaced".
The sentence contains the same grammar error that was flagged in a previous review. It should read "will be replaced" (past participle) instead of "will be replace."
📝 Proposed fix
-`|&` will be replace by a string of `className`. So if you want to add rules for `:hover`, use the string selector `|&:hover`. +`|&` will be replaced by a `className` string. So if you want to add rules for `:hover`, use the string selector `|&:hover`.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/guide/styles.md` at line 156, Fix the grammar in the sentence that explains the `|&` selector: change "will be replace" to "will be replaced" so the line reads "`|&` will be replaced by a string of `className`. So if you want to add rules for `:hover`, use the string selector `|&:hover`." Update the sentence containing the `|&` and `|&:hover` examples accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/guide/styles.md`:
- Line 113: The markdown code span containing `|1px solid ` has an accidental
trailing space inside the backticks; edit the text to remove the trailing space
so the span reads `|1px solid` (i.e., update the token in the
docs/guide/styles.md content where the code span `|1px solid ` appears).
---
Duplicate comments:
In `@docs/guide/styles.md`:
- Line 156: Fix the grammar in the sentence that explains the `|&` selector:
change "will be replace" to "will be replaced" so the line reads "`|&` will be
replaced by a string of `className`. So if you want to add rules for `:hover`,
use the string selector `|&:hover`." Update the sentence containing the `|&` and
`|&:hover` examples accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a4917a48-94d5-4c6c-82d5-458ca511743c
📒 Files selected for processing (1)
docs/guide/styles.md
Summary by CodeRabbit
Refactor
Chores
Documentation