Skip to content

Make FossilisationDialog a CustomWindow #6704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IdfbAn wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make FossilisationDialog a CustomWindow #6704

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e04af68
Make FossilisationDialog a CustomWindow
IdfbAn Feb 3, 2026
28f3272
Fixed the uid mismatch in FossilisationDialog.tscn
hhyyrylainen Feb 6, 2026
a49351e
Revert the unintended parts of the previous commit
hhyyrylainen Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/thriveopedia/fossilisation/FossilisationDialog.tscn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
[ext_resource type="Script" uid="uid://dvtcoa6g3lkyn" path="res://src/thriveopedia/fossilisation/FossilisationDialog.cs" id="1"]
[ext_resource type="PackedScene" uid="uid://bhpjtbtaeunat" path="res://src/gui_common/CustomRichTextLabel.tscn" id="3"]
[ext_resource type="FontFile" uid="uid://dblvrxw3ue372" path="res://assets/fonts/Lato-Italic.ttf" id="3_cgult"]
[ext_resource type="PackedScene" uid="uid://cl64wvnxs6ivs" path="res://src/gui_common/dialogs/CustomConfirmationDialog.tscn" id="4"]
[ext_resource type="PackedScene" uid="uid://cl64wvnxs6ivs" path="res://src/gui_common/dialogs/CustomWindow.tscn" id="4"]
Copy link
Copy Markdown
Member

@hhyyrylainen hhyyrylainen Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't change the uid so this change does absolutely nothing, at least Godot Editor still shows it inheriting the confirmation dialog to me...

Copy link
Copy Markdown
Member

@hhyyrylainen hhyyrylainen Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure enough when I fix that, things actually start breaking so this PR still needs work (I'll commit my uid fix to this):

E 0:00:12:610   int System.Runtime.CompilerServices.CastHelpers.<IsInstanceOf_NoCacheLookup>g____PInvoke|4_0(System.Void*, int, System.Runtime.CompilerServices.ObjectHandleOnStack): System.InvalidCastException: Unable to cast object of type 'CustomWindow' to type 'CustomConfirmationDialog'.
  <C++ virhe>   System.InvalidCastException
  <C++ Lähde>   :0 @ int System.Runtime.CompilerServices.CastHelpers.<IsInstanceOf_NoCacheLookup>g____PInvoke|4_0(System.Void*, int, System.Runtime.CompilerServices.ObjectHandleOnStack)
  <Pinojäljitys>:0 @ int System.Runtime.CompilerServices.CastHelpers.<IsInstanceOf_NoCacheLookup>g____PInvoke|4_0(System.Void*, int, System.Runtime.CompilerServices.ObjectHandleOnStack)
                :0 @ int System.Runtime.CompilerServices.CastHelpers.<IsInstanceOf_NoCacheLookup>g____PInvoke|4_0(System.Void*, int, System.Runtime.CompilerServices.ObjectHandleOnStack)
                :0 @ object System.Runtime.CompilerServices.CastHelpers.ChkCastAny_NoCacheLookup(System.Void*, object)
                VariantUtils.generic.cs:398 @ T Godot.NativeInterop.VariantUtils.ConvertTo<T>(Godot.NativeInterop.godot_variant&)
                FossilisationDialog_ScriptProperties.generated.cs:61 @ bool FossilisationDialog.SetGodotClassPropertyValue(Godot.NativeInterop.godot_string_name&, Godot.NativeInterop.godot_variant&)
                CSharpInstanceBridge.cs:57 @ Godot.NativeInterop.godot_bool Godot.Bridge.CSharpInstanceBridge.Set(nint, Godot.NativeInterop.godot_string_name*, Godot.NativeInterop.godot_variant*)

[ext_resource type="PackedScene" uid="uid://b1boea8qjx6xx" path="res://src/gui_common/SpeciesDetailsPanel.tscn" id="5"]
[ext_resource type="Texture2D" uid="uid://baqkntjn5ng0y" path="res://assets/textures/gui/bevel/randomizeButton.png" id="9"]
[ext_resource type="Texture2D" uid="uid://c8qyts61c8a0y" path="res://assets/textures/gui/bevel/randomizeButtonActive.png" id="10"]
Expand Down