Open
Conversation
-Added robust scene loading with retries + cache bypass on retries (ResourceLoader.CacheMode.Ignore) in SceneLoadHelpers.cs. -Updated scene transitions to use that helper and fail fast if all attempts fail -Hardened Thriveopedia page creation so random scene instantiate failures don’t crash/load into broken state
Member
|
I think something pretty strange has happened here with git as all of the files show as being totally new and not modified existing files. |
Member
|
Related to the retry logic etc. I think that is sadly kind of a misplaced attempt, because the Godot Engine just flat out gives up at some point and no further scene loads ever work correctly. So we cannot do a workaround like this, because to actually get out of the buggy state we would have to get the entire game process restarted. And adding logic that maybe works around a few cases would mean that every single place in the game would need the same kind of retry, because if one scene fails and it is worked around the engine will just blow up in the next scene load that isn't guarded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Description of What This PR Does
-Added robust scene loading with retries + cache bypass on retries (ResourceLoader.CacheMode.Ignore) in SceneLoadHelpers.cs.
-Updated scene transitions to use that helper and fail fast if all attempts fail
-Hardened Thriveopedia page creation so random scene instantiate failures don’t crash/load into broken state
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.