Skip to content

fix issue #5075#6731

Open
RyuDanuer wants to merge 1 commit intoRevolutionary-Games:masterfrom
RyuDanuer:FIXING-ISSUE-#5075
Open

fix issue #5075#6731
RyuDanuer wants to merge 1 commit intoRevolutionary-Games:masterfrom
RyuDanuer:FIXING-ISSUE-#5075

Conversation

@RyuDanuer
Copy link
Copy Markdown

@RyuDanuer RyuDanuer commented Feb 13, 2026

Brief Description of What This PR Does

-Added robust scene loading with retries + cache bypass on retries (ResourceLoader.CacheMode.Ignore) in SceneLoadHelpers.cs.
-Updated scene transitions to use that helper and fail fast if all attempts fail
-Hardened Thriveopedia page creation so random scene instantiate failures don’t crash/load into broken state

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

-Added robust scene loading with retries + cache bypass on retries (ResourceLoader.CacheMode.Ignore) in SceneLoadHelpers.cs.
-Updated scene transitions to use that helper and fail fast if all attempts fail
-Hardened Thriveopedia page creation so random scene instantiate failures don’t crash/load into broken state
@hhyyrylainen
Copy link
Copy Markdown
Member

I think something pretty strange has happened here with git as all of the files show as being totally new and not modified existing files.

@hhyyrylainen
Copy link
Copy Markdown
Member

Related to the retry logic etc. I think that is sadly kind of a misplaced attempt, because the Godot Engine just flat out gives up at some point and no further scene loads ever work correctly. So we cannot do a workaround like this, because to actually get out of the buggy state we would have to get the entire game process restarted. And adding logic that maybe works around a few cases would mean that every single place in the game would need the same kind of retry, because if one scene fails and it is worked around the engine will just blow up in the next scene load that isn't guarded.

@hhyyrylainen hhyyrylainen moved this from In progress to started but stuck (help wanted) in Thrive Planning Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: started but stuck (help wanted)

Development

Successfully merging this pull request may close these issues.

2 participants