Conversation
| public Dictionary<string, string> OrganelleMap = null!; | ||
|
|
||
| [JsonRequired] | ||
| public Dictionary<string, List<string>> Processes = null!; |
There was a problem hiding this comment.
I think it would guard against typos if some of these lists used more types. For example this might work well as Dictionary<Compound, List<string>> that way the JSON would refuse to load if there's a typo in a compound name. And as an added bonus the compounds would get converted to int keys which should be much more efficient to access. Same could be maybe applied to the organelles etc.
Though in some cases due to the complexity of JSON loading, I've needed to split things into two parts: first loading into untyped collection and then in the Resolve method actually looking stuff up. This also keeps the benefits (prevents typos and values that can never happen) but is slightly harder to setup.
| "producing": [ | ||
| "geno", | ||
| "creo", | ||
| "geno", |
| "liking": [ | ||
| "amans", | ||
| "phila", | ||
| "phila", |
e325a38 to
432247a
Compare
to add more variety to the generation.
|
We are currently in feature freeze until the next release. |
Brief Description of What This PR Does
This PR includes a new name generator as suggested here.
This new generator uses more complex rules, based on organelles, processes and species characteristics, and yields consistent phonotactics and grammatical gender agreement.
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.