Changed cell specialisation calculation#6800
Changed cell specialisation calculation#6800Accidental-Explorer wants to merge 13 commits intomasterfrom
Conversation
…on' into changed-specialisation-calculation
…on' into changed-specialisation-calculation
hhyyrylainen
left a comment
There was a problem hiding this comment.
Code change looks good to me now, but I won't comment on the gameplay / design side just yet.
|
I suppose this is compatible with #6825 (after fixing the merge conflict). But how necessary is this now? |
Still quite useful in my opinion. I don't think it's good that switching to eukaryotic organelles will provide a lower specialisation bonus. The equivalence change helps with the transition, but not the end point. Combined, the two changes completely fix the problem. Of course, in this PR I also remove the minimum size, but that's separate. |
|
|
||
| tempWorkMemory.TryGetValue(definition, out var existingCount); | ||
| tempWorkMemory[definition] = existingCount + 1; | ||
| tempWorkMemory[definition] = existingCount + hexCount; |
There was a problem hiding this comment.
Updating this count like this will break the tooltip (just commenting to remember about this as you said you didn't touch the tooltip side yet for this PR) as the tooltip will claim the player has way more organelles than they actually do.
There was a problem hiding this comment.
Very true! I was planning to either count the organelles themselves separately for the tooltip, or actually referring to organelle hexes (or size in some way) in the tooltip, since that would also inform the player of what is going on.
That makes me realise that in Master, the tooltip is now already a little bit off because it counts for example thylakoids in the number of chloroplasts. When I work on the tooltip, that's probably worth an "(or simpler equivalent)", or something like that.
There was a problem hiding this comment.
Not counting the organelle / part tooltips, this is already one of the longest tooltips in the game... so I think we are quickly reaching the point where any player seeing the tooltip will mentally give up before managing to read it.
Edit: just wanted to say why I didn't change it. The advice is still right that you should be adding more of the most common organelle even when it is said to be the eukaryotic equivalent.
Brief Description of What This PR Does
Makes some lighter changes to the cell specialisation calculation:
Tooltip not adjusted yet.
More extensive overhauls:
#6805 B
#6806 C
#6822 D
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.