Feature/nvmm support - #28
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 883deb5bd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if cc.has_header('gstnvdsmeta.h', | ||
| include_directories : deepstream_incdir) |
There was a problem hiding this comment.
In a normal Meson installation, gstnvdsmeta.h includes GStreamer headers from a pkg-config-provided directory such as /usr/include/gstreamer-1.0, but this compiler check receives only the DeepStream include directory. Although gst_dep was resolved earlier, Meson does not apply dependency flags to unrelated compiler checks automatically, so this test fails and silently leaves HAVE_DEEPSTREAM unset even when the full SDK is installed. Pass the GStreamer dependency to has_header, or probe the less-dependent nvdsmeta.h as the Autotools path does.
Useful? React with 👍 / 👎.
| idx += g_snprintf (&info[idx], GST_PERF_MSG_MAX_SIZE - idx, | ||
| "; ds-fps: %0.03f", ds_fps); |
There was a problem hiding this comment.
When a program assigns the element a name long enough to fill info, the first g_snprintf returns the number of characters it wanted to write, which can exceed GST_PERF_MSG_MAX_SIZE. This unconditional DeepStream append then evaluates &info[idx] beyond the array and underflows GST_PERF_MSG_MAX_SIZE - idx, causing an out-of-bounds write even with the default CPU-reporting setting; clamp or validate idx before appending.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
No description provided.