Vet clinic database: query and update table by Ridwanullahi-code · Pull Request #3 · Ridwanullahi-code/vet_clinic_database

Ridwanullahi-code · 2023-03-02T15:36:34Z

Add a column species of type string to your animal's table. Could you change your schema.sql file?
insert the data into the database
Inside a transaction update the animal's table by setting the species column to unspecified. Verify that the change was made. Then roll back the change and verify that the species columns returned to the state before the transaction.
Update the animals table by setting the species column to digimon for all animals that have a name ending in mon.
Update the animals table by setting the species column to pokemon for all animals that don't have species already set.
Commit the transaction.
Verify that change was made and persists after commit.
Write queries to answer the following questions:
How many animals are there?
How many animals have never tried to escape?
What is the average weight of animals?
Who escapes the most, neutered or not neutered animals?
What is the minimum and maximum weight of each type of animal?
What is the average number of escape attempts per animal type of those born between 1990 and 2000?
Take a screenshot of the results of your queries.

mukhammadrizooff

Hi @Ridwanullahi-code,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, please add descriptive informations to all parts of your README 👍🏼

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Gambit142

Hi @Ridwanullahi-code 👋 ,

Good job so far!

Highlights

Everything that creates or changes the structure of the tables is in the schema.sql file
Everything that populates tables with data is in the data.sql file
Everything that is a query that helps to analyze data is in the queries.sql file

There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Kindly check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

You can also consider:

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, remember to tag me in your question so I can receive the notification. You can tag me by typing @Gambit142

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Gambit142 · 2023-03-02T18:34:55Z

README.md


 This project is [MIT](./LICENSE) licensed.



The link to your LICENSE is broken and redirects to GitHub's error page. Kindly fix the LICENSE. You can add a valid LICENSE by following the instructions in this article. 👍 😎

Gambit142 · 2023-03-02T18:38:06Z

queries.sql

+BEGIN;
+DELETE FROM animals WHERE date_of_birth > '01/07/2022';
+SAVEPOINT savepoint_1;


This transaction should delete all animals born after Jan 1st, 2022 (01/01/2022) and not the 1st of July 2022(01/07/2022). Kindly correct the error so that the correct number of animals can be deleted. Please, don't forget to update the screenshot attached to your pull request summary 😎 💻

Gambit142 · 2023-03-02T18:42:10Z

queries.sql

+
+SELECT COUNT(*) FROM animals;
+


The total number of animals should be 10 and not 11. By the time you update the transactions that should delete all animals born after 01/01/2022, you would have 10 as the total number of animals. Kindly update the screenshot for this query after the transaction. 👍 💻

Gambit142 · 2023-03-02T18:45:56Z

queries.sql

+
+SELECT AVG(weight_kg) FROM animals
+


The average weight of animals should be 15.55 and not 16.136363 . By the time you update the transactions that should delete all animals born after 01/01/2022, you would have 15.55 as the average weight of animals. Kindly update the screenshot for this query after the transaction. 👍 💻

Gambit142 · 2023-03-02T18:52:02Z

queries.sql

+SELECT name FROM animals
+ORDER BY escape_attempts DESC LIMIT 1;


This query should return a result that shows who attempts to escape the most classified by the neutered character of the animals. Currently, you have the name of the animals who attempted to escape the most but it should be an analysis of animals based on the neutered character. In the end, your result should look familiar to this:

Please remember to update the screenshot when you are done. 👍

Gambit142 · 2023-03-02T18:57:15Z

queries.sql

+
+SELECT MIN(weight_kg), MAX(weight_kg) FROM animals GROUP BY(species);
+


The maximum weight of pokemon animals should be 17 and not 22. By the time you update the transactions that should delete all animals born after 01/01/2022, you would have 17 as the maximum weight of pokemon animals. Kindly update the screenshot for this query after the transaction. 👍 💻

jasonfelice

Hi @Ridwanullahi-code,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

As I can see, you didn't update the queries as requested by the previous reviewer. Please update the queries as per requirement and update the screenshots in the PR description.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

KayLemba

[[# STATUS: APPROVED 🟢 👏

Hello @Ridwanullahi-code ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉 Keep up the good work 🥂

HIGHLIGHTS:

Your repo is professional 😎
Descriptive P.R 💯
linters are passing
Professional README 💯
Everything relating to the database is working.

Now you can merge this branch and move on 🥇
Happy Coding cheers 🥇 💯

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.]]

complete quering and updating table

2627d40

mukhammadrizooff reviewed Mar 2, 2023

View reviewed changes

last update

00b66f1

Gambit142 suggested changes Mar 2, 2023

View reviewed changes

last change

701ab5c

jasonfelice suggested changes Mar 3, 2023

View reviewed changes

ridwanullahi added 3 commits March 3, 2023 19:17

last change

779b0af

add screenshot

6cb41a9

add screenshot

85d3c67

KayLemba approved these changes Mar 3, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vet clinic database: query and update table#3

Vet clinic database: query and update table#3
Ridwanullahi-code wants to merge 6 commits intodevelopmentfrom
update_query_table

Ridwanullahi-code commented Mar 2, 2023 •

edited

Loading

Uh oh!

mukhammadrizooff left a comment

Uh oh!

Gambit142 left a comment

Uh oh!

Gambit142 Mar 2, 2023

Uh oh!

Gambit142 Mar 2, 2023

Uh oh!

Gambit142 Mar 2, 2023

Uh oh!

Gambit142 Mar 2, 2023

Uh oh!

Gambit142 Mar 2, 2023

Uh oh!

Gambit142 Mar 2, 2023

Uh oh!

jasonfelice left a comment

Uh oh!

KayLemba left a comment •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		SELECT name FROM animals
		ORDER BY escape_attempts DESC LIMIT 1;


		SELECT MIN(weight_kg), MAX(weight_kg) FROM animals GROUP BY(species);

Conversation

Ridwanullahi-code commented Mar 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mukhammadrizooff left a comment

Choose a reason for hiding this comment

Invalid Code Review Request

Uh oh!

Gambit142 left a comment

Choose a reason for hiding this comment

Highlights

Required Changes ♻️

Optional suggestions

Please, remember to tag me in your question so I can receive the notification. You can tag me by typing @Gambit142

Uh oh!

Gambit142 Mar 2, 2023

Choose a reason for hiding this comment

Uh oh!

Gambit142 Mar 2, 2023

Choose a reason for hiding this comment

Uh oh!

Gambit142 Mar 2, 2023

Choose a reason for hiding this comment

Uh oh!

Gambit142 Mar 2, 2023

Choose a reason for hiding this comment

Uh oh!

Gambit142 Mar 2, 2023

Choose a reason for hiding this comment

Uh oh!

Gambit142 Mar 2, 2023

Choose a reason for hiding this comment

Uh oh!

jasonfelice left a comment

Choose a reason for hiding this comment

Required Changes ♻️

Optional suggestions

Uh oh!

KayLemba left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Ridwanullahi-code commented Mar 2, 2023 •

edited

Loading

KayLemba left a comment •

edited

Loading