Fix tire search dropdown: no results + icon overlap - #178
Merged
Conversation
1. The tire data was passed to JS as flat numeric arrays via get_tires_as_array(), but tire-review.js accessed properties by name (t.brand, t.model, etc.), making every field undefined and the search haystack always empty. Now maps the flat rows into lightweight objects with named keys before localizing. 2. The search icon used a Font Awesome <i> class, but FA fonts may not load on the standalone page due to CSP restrictions. Replaced with an inline SVG so the icon always renders and never overlaps input text. https://claude.ai/code/session_01BAc9aiNw9dh4GeqEkpkxLK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tire data was passed to JS as flat numeric arrays via get_tires_as_array(), but tire-review.js accessed properties by name (t.brand, t.model, etc.), making every field undefined and the search haystack always empty. Now maps the flat rows into lightweight objects with named keys before localizing.
The search icon used a Font Awesome class, but FA fonts may not load on the standalone page due to CSP restrictions. Replaced with an inline SVG so the icon always renders and never overlaps input text.
https://claude.ai/code/session_01BAc9aiNw9dh4GeqEkpkxLK