Skip to content

[WIP] - Inform when there is no minor version #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Ferror wants to merge 3 commits into
base: 8.0.x
Choose a base branch
from
Draft

[WIP] - Inform when there is no minor version #668

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37d2f0a
[WIP] - Inform when there is no minor version
Ferror Oct 21, 2022
59999b8
Instead of exception let's just inform
Ferror Oct 23, 2022
20d05f9
test and minor fix
Ferror Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Git/PickLastMinorVersionFromCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ public function assert(Version $version): bool
return ! $version->isPreRelease();
}
});

if ($stableVersions->isEmpty()) {
throw new \Exception('Your library does not have any minor version');
Copy link
Copy Markdown
Member

@Ocramius Ocramius Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a crash really the best approach? Perhaps it should be "green" when no BC breaks are detected instead?

Copy link
Copy Markdown
Author

@Ferror Ferror Oct 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. That's why I kinda put it as a draft with WIP. And yes when there is no stable version - there won't be any BC breaks. Note or Info message could be applied.

Stay tuned 😄

}

$versionsSortedDescending = $stableVersions->sortedDescending();

Expand Down