Add desugaring to fixed point - #4080
Closed
CohenArthur wants to merge 3 commits into
Closed
Conversation
CohenArthur
force-pushed
the
fixed-point-desugar
branch
from
August 14, 2025 13:06
eff7800 to
433205c
Compare
Collaborator
|
I don't think desugaring needs to be fixed point -- unless the resolver is supposed to rely on things being desugared to complete resolution? It seems like the macro issues are all problems local to |
gcc/rust/ChangeLog: * Make-lang.in: Compile it. * ast/rust-builtin-ast-nodes.h: Add missing methods for getting pointers. * ast/rust-expr.h: Likewise. * ast/rust-item.h: Likewise. * ast/rust-path.h: Likewise. * ast/rust-pattern.h: Likewise. * ast/rust-type.h: Likewise. * ast/rust-ast-pointer-visitor.cc: New file. * ast/rust-ast-pointer-visitor.h: New file.
gcc/rust/ChangeLog: * ast/rust-expression-yeast.cc (ExpressionYeast::dispatch): Rename to... (ExpressionYeast::reseat): ...this. (ExpressionYeast::visit): Remove. * ast/rust-expression-yeast.h: Inherit from PointerVisitor, override reseat instead of declaring dispatch.
gcc/rust/ChangeLog: * expand/rust-expand-visitor.cc: Remove old visitors. * expand/rust-expand-visitor.h: Likewise, plus inherit from PointerVisitor.
CohenArthur
force-pushed
the
fixed-point-desugar
branch
from
August 25, 2025 13:54
433205c to
fc27022
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking this as a draft since it might not be what we actually want, but we do get a lot further when expanding macros in
core. For example, things likewrite!(fmt, ...)?;now work properly. Note that this may also be because the ExpandVisitor is lacking in many places... so just looking for comments on this for now