gccrs: Improve rust_debug formatting - #4783
Draft
powerboat9 wants to merge 2 commits into
Draft
Conversation
powerboat9
force-pushed
the
simple-diag
branch
from
August 16, 2026 05:09
ff6282c to
c7613c9
Compare
ChangeLog: * .github/glibcxx_ubuntu64b_log_expected_warnings: Add warnings. * .github/log_expected_warnings: Likewise. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
powerboat9
force-pushed
the
simple-diag
branch
from
August 16, 2026 13:20
c7613c9 to
13d344b
Compare
Collaborator
Author
|
@philberty is this good to merge? |
This was referenced Aug 16, 2026
philberty
reviewed
Aug 16, 2026
| #include "rust-system.h" | ||
|
|
||
| // TODO: remove | ||
| #pragma GCC diagnostic ignored "-Wformat-diag" |
Member
There was a problem hiding this comment.
whats going on with all the #pragma GCC diagnostic ignored "-Wformat-diag"
Collaborator
Author
There was a problem hiding this comment.
With the change from printf to GCC diagnostic formatting, GCC starts warning about diagnostic quality (excess punctuation, unquoted identifiers, etc).
Member
There was a problem hiding this comment.
i'm not sure what to review here whats the improvement maybe i cant see it with all the diff
Collaborator
Author
There was a problem hiding this comment.
It switches from printf style formatting (no %qs, %<, %>, %m, %r, %R, etc) to our implementation of GCC diagnostic style formatting (backwards compatible and with support for %qs, %<, %>, and %m, but not everything supported by GCC's main diagnostics system) for debug printing. #4784 is a follow up that switches us over to using GCC diagnostic formatting proper.
This allows rust_debug to use (an ad-hoc implementation of) gcc diagnostic formatting. To keep this patch as small as possible, proper fixes for -Wformat-diag are mostly left for future patches. gcc/rust/ChangeLog: * ast/rust-ast.cc: Ignore -Wformat-diag. * backend/rust-compile-base.cc: Likewise. * backend/rust-compile-expr.cc: Likewise. * backend/rust-compile-stmt.cc: Likewise. * backend/rust-mangle-v0.cc: Likewise. * checks/errors/borrowck/rust-bir-builder.h: Likewise. * checks/errors/borrowck/rust-bir-fact-collector.h: Likewise. * checks/errors/rust-hir-pattern-analysis.cc: Likewise. * expand/rust-cfg-strip.cc: Likewise. * expand/rust-macro-builtins-asm.cc: Likewise. * expand/rust-macro-builtins-log-debug.cc: Likewise. * hir/tree/rust-hir.cc: Likewise. * lex/rust-lex.cc: Likewise. * parse/rust-parse-impl-lexer.cc: Likewise. * parse/rust-parse-impl-macro.cc: Likewise. * resolve/rust-forever-stack.hxx: Likewise. * rust-diagnostics.cc (rust_debug_loc): Use expand_message. * rust-diagnostics.h (rust_debug_loc): Change formatting attribute. * rust-lang.cc (grs_langhook_parse_file): Change debug message. * rust-session-manager.cc: Ignore -Wformat-diag. * typecheck/rust-autoderef.cc: Likewise. * typecheck/rust-casts.cc: Likewise. * typecheck/rust-coercion.cc: Likewise. * typecheck/rust-hir-dot-operator.cc: Likewise. * typecheck/rust-hir-type-check-expr.cc: Likewise. * typecheck/rust-hir-type-check-path.cc: Likewise. * typecheck/rust-hir-type-check-type.cc: Likewise. * typecheck/rust-type-util.cc: Likewise. * typecheck/rust-tyty-bounds.cc: Likewise. * typecheck/rust-tyty-subst.cc: Likewise. * typecheck/rust-tyty-variance-analysis.cc: Likewise. * typecheck/rust-tyty.cc: Likewise. * typecheck/rust-unify.cc: Likewise. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
powerboat9
force-pushed
the
simple-diag
branch
from
August 16, 2026 19:10
13d344b to
62585d6
Compare
powerboat9
marked this pull request as draft
August 16, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows
rust_debugto use (an ad-hoc implementation of) gcc diagnostic formatting. To keep this patch as small as possible, proper fixes for-Wformat-diagare mostly left for future patches.