Skip to content

ed448-goldilocks: initial import#1219

Merged
tarcieri merged 21 commits into
RustCrypto:masterfrom
baloo:baloo/ed448
Jun 4, 2025
Merged

ed448-goldilocks: initial import#1219
tarcieri merged 21 commits into
RustCrypto:masterfrom
baloo:baloo/ed448

Conversation

@baloo

@baloo baloo commented Jun 1, 2025

Copy link
Copy Markdown
Member

Imports source code from: https://github.com/crate-crypto/Ed448-Goldilocks

Another take on #1208 that doesn't pull the macros from primeorder.

mikelodder7 and others added 10 commits May 31, 2025 21:12
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Comment thread ed448/src/curve/edwards/extended.rs Outdated
pub fn hash<X>(msg: &[u8], dst: &[u8]) -> Self
where
X: for<'a> ExpandMsg<'a>,
X: ExpandMsg<U32>,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @daxpedda

I would have expected to use U84, but I'm not sure I understand why that doesn't work.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generic here should be the variable k, which for Curve/Ed448 is 224 bits. So this should be U28.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hence the CollisionResistance relationship

Comment thread ed448/src/macros.rs
@baloo
baloo force-pushed the baloo/ed448 branch 2 times, most recently from 4ccd812 to d70bd44 Compare June 2, 2025 05:21
Comment thread ed448/Cargo.toml Outdated
@tarcieri

tarcieri commented Jun 4, 2025

Copy link
Copy Markdown
Member

@baloo can you also rename the containing directory and CI workflow to ed448-goldilocks?

(FWIW, it's the original published name of this curve: https://eprint.iacr.org/2015/625.pdf)

Also looks like you need a rustfmt

@baloo baloo changed the title Add ed448 ed448-goldilocks: import crate Jun 4, 2025
@baloo baloo changed the title ed448-goldilocks: import crate ed448-goldilocks: initial import Jun 4, 2025
@tarcieri
tarcieri merged commit c797d60 into RustCrypto:master Jun 4, 2025
151 checks passed
@baloo
baloo deleted the baloo/ed448 branch June 4, 2025 18:32
@tarcieri tarcieri mentioned this pull request Jun 5, 2025
@tarcieri

tarcieri commented Jun 5, 2025

Copy link
Copy Markdown
Member

@kevaundray can you add me as an owner of the ed448-goldilocks crate?

@baloo

baloo commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

@tarcieri

tarcieri commented Jun 5, 2025

Copy link
Copy Markdown
Member

@baloo yeah, already asked here: RustCrypto/signatures#990 (comment)

@dignifiedquire

Copy link
Copy Markdown
Member

what would be the best place to PR in x448?

@kevaundray

Copy link
Copy Markdown

@kevaundray can you add me as an owner of the ed448-goldilocks crate?

I just added your username, can you confirm you received it?

@tarcieri

tarcieri commented Jun 6, 2025

Copy link
Copy Markdown
Member

@kevaundray got them both, thanks!

Not sure about x448. We can either put it under elliptic-curves or possibly KEMs, though it isn't really a KEM.

@kevaundray can you add me as an owner of x448 too?

@kevaundray

Copy link
Copy Markdown

@kevaundray got them both, thanks!

Not sure about x448. We can either put it under elliptic-curves or possibly KEMs, though it isn't really a KEM.

@kevaundray can you add me as an owner of x448 too?

added you to that too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants