ed448-goldilocks: initial import#1219
Conversation
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
Signed-off-by: Michael Lodder <mike@litprotocol.com>
| pub fn hash<X>(msg: &[u8], dst: &[u8]) -> Self | ||
| where | ||
| X: for<'a> ExpandMsg<'a>, | ||
| X: ExpandMsg<U32>, |
There was a problem hiding this comment.
cc @daxpedda
I would have expected to use U84, but I'm not sure I understand why that doesn't work.
There was a problem hiding this comment.
The generic here should be the variable k, which for Curve/Ed448 is 224 bits. So this should be U28.
There was a problem hiding this comment.
hence the CollisionResistance relationship
4ccd812 to
d70bd44
Compare
|
@baloo can you also rename the containing directory and CI workflow to (FWIW, it's the original published name of this curve: https://eprint.iacr.org/2015/625.pdf) Also looks like you need a |
|
@kevaundray can you add me as an owner of the |
|
@baloo yeah, already asked here: RustCrypto/signatures#990 (comment) |
|
what would be the best place to PR in x448? |
I just added your username, can you confirm you received it? |
|
@kevaundray got them both, thanks! Not sure about @kevaundray can you add me as an owner of |
added you to that too :) |
Imports source code from: https://github.com/crate-crypto/Ed448-Goldilocks
Another take on #1208 that doesn't pull the macros from primeorder.