Skip to content

chacha20: apply unreachable_pub lint#570

Merged
newpavlov merged 6 commits into
masterfrom
chacha20/unreachable_pub
Jun 15, 2026
Merged

chacha20: apply unreachable_pub lint#570
newpavlov merged 6 commits into
masterfrom
chacha20/unreachable_pub

Conversation

@newpavlov

@newpavlov newpavlov commented Jun 15, 2026

Copy link
Copy Markdown
Member

Re-exports Nonce and ChaCha20LegacyCore.

In a future breaking release we probable should just make legacy, rng, and xchacha modules public instead of re-exporting them.

Closes #569

@newpavlov newpavlov requested a review from tarcieri June 15, 2026 00:30
@newpavlov

newpavlov commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

Huh, it looks like Intel has started to block curl downloads. The archive is downloaded fine using browser, but I get an empty file using curl and wget. Simply adding a user agent did not help.

UPD: According to this issue, it looks like a JS-based challenge was added for the download. I guess we should just upload a copy of the tarball to RustCrypto/actions.

@tarcieri

Copy link
Copy Markdown
Member

I can look into fixing the avx512 job and getting everything migrated to the shared action to install the SDE in https://github.com/RustCrypto/actions

@newpavlov

Copy link
Copy Markdown
Member Author

Note that we do not use the shared job here, so the chacha20 config would have to be updated as well.

@newpavlov newpavlov merged commit 57cb130 into master Jun 15, 2026
32 checks passed
@newpavlov newpavlov deleted the chacha20/unreachable_pub branch June 15, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chacha20: reexport the Nonce type

2 participants