Skip to content

Fix averaging grades when list is empty #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RustySnek merged 1 commit into from
Mar 30, 2026
Merged

Fix averaging grades when list is empty #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ git clone https://github.com/RustySnek/librus-apix
cd librus-apix
python -m venv venv
source ./venv/bin/activate
pip install requirements.txt
pip install -r requirements.txt
# Installing library with editable flag
pip install -e .
```
2 changes: 1 addition & 1 deletion librus_apix/grades.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def _extract_grades_numeric(
sem_grades[semester_number][subject].append(g)
avg_gr = (
average_grades[semester_number]
if len(average_grades) >= semester_number
if len(average_grades) > semester_number
else 0.0
) # might happen that the list is empty
gpa = Gpa(semester_number + 1, avg_gr, subject)
Expand Down
Loading