Age groups#276
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 4074 4079 +5
=========================================
+ Hits 4074 4079 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KCGallagher
requested changes
Jun 26, 2025
KCGallagher
approved these changes
Jun 26, 2025
KCGallagher
left a comment
KCGallagher
left a comment
Contributor
There was a problem hiding this comment.
All looks good! Though, just to check, have you plotted the age histograms by both age and age group to confirm that they match?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new function to update the age groups after manually assigning ages to children in households of three people or more.
Further work
NA
Checklist
All new functions have docstrings in the correct style
I've verified the complete docs build locally without errors
I've maintained 100% coverage (please mention any 'no cover' annotations explicitly)
I've unit-tested all new methods directly
[] Breaking change (fix or feature that would cause existing functionality to change)
[] I have read the CONTRIBUTING document.
[] My code follows the code style of this project.
[] I have updated the wiki with new parameters/model functionality