fix(ha): emit retain as JSON boolean in discovery payloads#459
Merged
Conversation
str(retain).lower() produced the Python strings "true"/"false" which json.dumps serialized as JSON strings. Home Assistant's MQTT discovery schema expects a boolean; the string caused schema validation to reject the retain flag, so command topics for number/select entities were not retained on the broker and gateway settings were lost after an HA restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str(retain).lower()inHaBaseSwitch/ select / number discovery methods produced Python strings"true"/"false"whichjson.dumpsserialized as JSON stringsretainflagnumberandselectentities (refresh periods, target SoC) were not retained on the broker, so gateway settings were lost after every HA restartretaindirectly — it is already aboolTest plan
test_discovery_retain.pytests updated to assertTrue/Falseinstead of"true"/"false"— all 293 tests pass