Standardize trace_particle_through_mesh#143
Open
Fuad-HH wants to merge 10 commits into
Open
Conversation
- passing all tests except smoke_test_particle It is giving a warning for MPI oversubscribing and "Structure not initalized at Particle"
- passing all tests
instead of checking if tol was passed using negative values, it is made optional. In the future, tol will be calculated outside according to the standardization plan and for this reason, we don't need it to be passed as reference or pointer
it is passed as a parameter rather than computing it every time the search is called.
it's an initial step to make the function standard with proper docuemntation. [important] there are some breaking changes and the function is under heavy development
the functor decides what happens to the particles at the boundary
next_element parameter holds the next element when a particle intersects a face. This is added to both the trace_particle_through_mesh and the functor. The functor may or may not use the value, but there's a high chance to be used. [Important] The test is failing. This is because although the particles doesn't intersect face 0 (it is along the way of the ray going forward) the closeness algorithm finds it as the intersected face.
Contributor
Author
|
@jacobmerson I will keep it draft until I bring the test case here. But please start reviewing the changes. I will commit the new test case for |
- works for particles going to a new element - or remains in the same - [to be fixed] particles leaking out
next_element becomes -1 when particle leaks
fix search_mesh in accordance with changes in trace_particle_through_mesh [future fixes] - interPoints should give the face intersection location when leaking out instead of the destination
9 tasks
jacobmerson
reviewed
Feb 28, 2025
jacobmerson
left a comment
jacobmerson
left a comment
Contributor
There was a problem hiding this comment.
I put some relevant comments here: #144
Mostly just a few naming things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ray_intersects_trianglewithline_segment_intersects_triangle.set_new_elementfunction inside the functor.next_elementparameter that holds the next element and passes to the functor.find_exit_facesearch_mesh*After adding the callback functor, it is necessary for the user to know a clearly defined meaning of the particle state arrays.