Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Param.oid_aliases field comment in the protobuf to reflect updated guidance around alias usage in the device model.
Changes:
- Revised the documentation comment for
repeated string oid_aliases = 17;to describe alias conflict constraints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NR-RV
requested changes
Jul 7, 2026
Co-authored-by: Nathan Rochon <nathan.rochon@rossvideo.com>
NR-RV
approved these changes
Jul 7, 2026
abrown-RV
deleted the
55-decide-schema-validation-rules-for-oid_aliases-to-align-docs-without-breaking-existing-devices
branch
July 7, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the oid_aliases comment to reflect the decision to leave oid_aliases schema as
type: string