Fix building with old Clang versions#87
Merged
Merged
Conversation
Currently, when compiling with an old clang, it will just pick the latest stdlib, which breaks, since it doesn’t support newer C++ features. This tries to find a compatible one. Compatibility is roughly determine by the version number. We need the main includes as well as the architecture specific bits. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
Signed-off-by: Stefan Marr <git@stefan-marr.de>
smarr
force-pushed
the
fix-clang-stdlib-incompatibility
branch
from
51875f3 to
81e4654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when compiling with an old clang, it will just pick the latest stdlib/C++ includes, which breaks, since it doesn’t support newer C++ features.
This PR adds logic to find a compatible set of C++ headers.
Compatibility is roughly determine by the version number.
We need the main includes as well as the architecture specific bits.
It also fixes the GitLab CI setup, to include the local path to find rebench after we change the deployment method.