Add support for GPT-5 family and recent OpenAI o-series models#238
Open
cterdam wants to merge 1 commit intoSakanaAI:mainfrom
Open
Add support for GPT-5 family and recent OpenAI o-series models#238cterdam wants to merge 1 commit intoSakanaAI:mainfrom
cterdam wants to merge 1 commit intoSakanaAI:mainfrom
Conversation
…penAI models GPT-5 models require max_completion_tokens instead of max_tokens (the latter raises "Unsupported parameter" errors). This updates both get_response_from_llm and get_batch_responses_from_llm to use the correct parameter for GPT-5 models while preserving max_tokens for older GPT-4 models. Also adds o4-mini to the o-series routing in get_response_from_llm and create_client. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVAILABLE_LLMSAVAILABLE_LLMSget_response_from_llmandget_batch_responses_from_llmto usemax_completion_tokensinstead ofmax_tokensfor GPT-5 models, since the latter raisesUnsupported parameter: 'max_tokens' is not supported with this modelo4to the o-series routing inget_response_from_llmandcreate_clientso o4-mini is handled correctlyTest plan
max_completion_tokensand complete successfullymax_tokensand are unaffectedget_batch_responses_from_llm🤖 Generated with Claude Code