fix: strip trailing whitespace failing CI format - #275
Merged
SakiRinn merged 3 commits intoAug 17, 2026
Conversation
Ctrl+Scroll over the original or translated caption card adjusts its font size independently (clamped to StyleConsts MIN/MAX_FONT_SIZE). Sizes persist via MainWindowState (OriginalFontSize/TranslatedFontSize, defaults 15/18 matching previous fixed values). Useful for language learning: e.g. large original text with a smaller translation below. The previous auto-shrink of the translated caption (18 -> 15 when text is long) is removed, since it would silently override the user's chosen size. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Add adjustable caption font sizes on main window (Ctrl+Scroll)
Two blank lines carry trailing whitespace, so the "Check code formatting" step (dotnet format --verify-no-changes) exits 1. The CI/CD Pipeline has failed on master since these were introduced, and because pull_request builds check out the simulated merge with the base branch, every open PR inherits the red check. Whitespace only; no behaviour change.
Owner
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Check code formattingstep (dotnet format --verify-no-changes) currently fails onmaster, which turns every open PR red:Both are blank lines that carry trailing whitespace. Since
pull_requestbuilds check out the simulated merge with the base branch, the failure is inherited by PRs that do not touch these files.This PR removes the trailing whitespace on those two lines. Whitespace only, no behaviour change.