feat: optimize multi-pattern search using Aho–Corasick algorithm#157
Merged
Samarth2190 merged 1 commit intoSamarth2190:mainfrom Oct 31, 2025
Merged
Conversation
Replace the Rabin–Karp–based implementation in checkMultiplePatterns with an Aho–Corasick automaton for efficient simultaneous pattern matching. This reduces the time complexity from O(p·n) to O(Σm + n + matches), where p is the number of patterns, n is the length of the text, and Σm is the total length of all patterns. The new approach eliminates redundant re-scans of the text and significantly improves performance for large pattern sets.
Contributor
Author
|
@Samarth2190 Hi, could you please review this PR? |
Owner
|
Great implementation. Noted a few minor code quality improvements which are non-blocking and can be fixed in future iterations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Rabin–Karp–based implementation in checkMultiplePatterns with an Aho–Corasick automaton for efficient simultaneous pattern matching.
This reduces the time complexity from O(p·n) to O(Σm + n + matches), where p is the number of patterns, n is the length of the text, and Σm is the total length of all patterns.
The new approach eliminates redundant re-scans of the text and significantly improves performance for large pattern sets.