Skip to content

[MPQEditor] Implement webviewPanel init.#1525

Merged
seanshpark merged 1 commit intoSamsung:mainfrom
stamalakhov:manual_MPQ_panel_br
Apr 17, 2023
Merged

[MPQEditor] Implement webviewPanel init.#1525
seanshpark merged 1 commit intoSamsung:mainfrom
stamalakhov:manual_MPQ_panel_br

Conversation

@stamalakhov
Copy link
Copy Markdown
Contributor

This commit implements webviewPanel initialization and update.

Its correctness is tested in #1511.

Fresh draft: #1511
Previous draft: #1505
Related: #1491

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com

@stamalakhov stamalakhov self-assigned this Apr 14, 2023
Comment thread src/MPQEditor/MPQEditor.ts Outdated
Comment on lines 274 to 276
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, this comment is needless. please remove.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
@seanshpark @dayo09
done.

dayo09
dayo09 previously approved these changes Apr 17, 2023
Copy link
Copy Markdown
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me :-D
Let me know when you are ready :-D

This commit implements webviewPanel initialization and update.

ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <s.malakhov@partner.samsung.com>
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit cc00550 into Samsung:main Apr 17, 2023
@stamalakhov stamalakhov deleted the manual_MPQ_panel_br branch April 17, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants