[MPQEditor] Implement 'dispose' and 'onViewMessage'#1539
[MPQEditor] Implement 'dispose' and 'onViewMessage'#1539seanshpark merged 1 commit intoSamsung:mainfrom
Conversation
This commit implements 'dispose' and 'onViewMessage' for manual mixed precision quantization task. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <s.malakhov@partner.samsung.com>
| // TODO | ||
| public onViewMessage(message: any) { | ||
| switch (message.command) { | ||
| case MessageDefs.selection: |
There was a problem hiding this comment.
I've got some UI feedbacks. If it's not easy to handle on this pr, please may you consider it later.
On #1505 draft,
- when I click on 'add' node, MPQEditor seems to adds the node to the mpq editor slot.
- when I click on 'Place holder's or 'Add 2' node, as they are not the
mpqtarget, they shows the property view on the right side of the circle editor.
I think that 'click' event must result in the same behavior.
We can choose either to open the property view same to 'add' operation or not to open the property view to other operations.
There was a problem hiding this comment.
@dayo09
Thank you. I'll try to fix it in the draft at first.
There was a problem hiding this comment.
@dayo09 @seanshpark
The same behaviour in the netron:
click on input/output nodes shows Model Properties, while clicking on the internal nodes show Nodes Properties.
For MPQ draft clicking internal nodes results in their selection for editing, while for input/output nodes still shows Model Properties to observe input/output size and theirs type.
To handle this issue:
- We can hide input/output nodes
- We can disable clicking input/output nodes
But still there may be some issues that some users are used to observe input/output size.
IMHO.
There was a problem hiding this comment.
Or 3. We can show Properties too, when clicking on the internal nodes(ex. Add).
There was a problem hiding this comment.
I will approve this PR, let's go on about it on the other issue or PR. Thanks for listening to me.!
There was a problem hiding this comment.
I will approve this PR, let's go on about it on the other issue or PR. Thanks for listening to me.!
Thank you very much!
|
Hi, this is another UI feedback.
It seems that : In the (1) area, it decides the default quantization configuration and (2) area specifies the per-node(layer) quantization configuration. At first look, I didn't understand what the (1) area would do. From my point of view, I propose to add 'Set default quantization' 'Set specific layer's quantization' in each areas. |
@dayo09 |
@dayo09 |
Sure :-D Thanks a lot :-D |
3 participants
This commit implements 'dispose' and 'onViewMessage' for manual mixed precision quantization task.
Its correctness is tested in #1530
Fresh draft: #1530
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com